[dotnet] Be more friendly for single file publishing and native compilation #12045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Were you able to build this to test that Selenium Manager works with the changes? I just created #12047 which could help with that.
|
CI for .net building already uses selenium manager (cannot put a link to PR cauze I am on mobile). |
|
Ah, and yes, I have tested it locally. |
seems no cases to entrace into this if statement
|
Link to Pr where selenium manager is used for internal testing by default: #11871 |
diemol
approved these changes
May 16, 2023
|
Hello. When would you deploy new binary with this fix? |
|
End of May we plan to do a new release. |
|
Fix ?? Bro |
When update bro |
|
soon. we'll announce it on our blog when it is ready — https://www.selenium.dev/blog/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No major changes, just use APIs which are supported in native compilation.
Motivation and Context
Selenium is a library, and I don't see reasons why this library cannot be friendly for native compilation.
Addresses:
Area to be improved
"selenium-manager.exe" is packed in nuget package. When user consumes nuget package, then binaries (for all platforms) are copied to user's output. In case of single file publishing the situation is resolved in this PR - binaries are copied to output as they are expected to be there.
In case of native compilation (
PublishAOTbuild property we need to be smarter: