Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] [run python] Upgrade GitHub Actions #11257

Merged
merged 4 commits into from
Nov 27, 2022
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 12, 2022

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

[py]
[run python]

Upgrades to match:

See Node.js 12 actions deprecation warnings at https://github.com/SeleniumHQ/selenium/actions/runs/3449658980

Motivation and Context

Improved performance and compatibility. See release notes above.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure upgrade

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2022

CLA assistant check
All committers have signed the CLA.

@cclauss cclauss changed the title [run python] Upgrade GitHub Actions [py] [run python] Upgrade GitHub Actions Nov 12, 2022
@cclauss
Copy link
Contributor Author

cclauss commented Nov 12, 2022

Python-related GitHub Actions do not run when Python files are modified.

@cclauss cclauss mentioned this pull request Nov 12, 2022
9 tasks
@diemol
Copy link
Member

diemol commented Nov 13, 2022

@cclauss we have a script to determine which build targets to run, as we use bazel. Our script has room for improvement, it determines the build targets based on the changed code files. Since the GitHub Actions files are not Python code, the workflow does not run.

To force the execution, make a temporal change to one of the .py files, and after it runs, you can revert it.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 13, 2022

Yes. Both the Python files that were modified in #11258 were modified in this PR and neither one of them woke up bazel.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 13, 2022

GitHub Actions paths already has filter patterns like **.py so perhaps that would be a safer, simpler approach.

@diemol
Copy link
Member

diemol commented Nov 14, 2022

GitHub Actions paths already has filter patterns like **.py so perhaps that would be a safer, simpler approach.

@cclauss yes, but this would execute all build and test targets for the code, which is less than ideal. With the script we have, we build and test only what gets affected by the code change. It is not perfect as it ignores changes like the one you are submitting.

@titusfortner titusfortner added this to the 4.7 milestone Nov 24, 2022
@titusfortner titusfortner merged commit c3a8c94 into SeleniumHQ:trunk Nov 27, 2022
@cclauss cclauss deleted the patch-1 branch November 27, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants