-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] [run python] Upgrade GitHub Actions #11257
Conversation
Python-related GitHub Actions do not run when Python files are modified. |
@cclauss we have a script to determine which build targets to run, as we use bazel. Our script has room for improvement, it determines the build targets based on the changed code files. Since the GitHub Actions files are not Python code, the workflow does not run. To force the execution, make a temporal change to one of the |
Yes. Both the Python files that were modified in #11258 were modified in this PR and neither one of them woke up bazel. |
GitHub Actions paths already has filter patterns like |
@cclauss yes, but this would execute all build and test targets for the code, which is less than ideal. With the script we have, we build and test only what gets affected by the code change. It is not perfect as it ignores changes like the one you are submitting. |
[py] [run python] Upgrade GitHub Actions
//py Java distribution: 'adopt'
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
[py]
[run python]
Upgrades to match:
See Node.js 12 actions deprecation warnings at https://github.com/SeleniumHQ/selenium/actions/runs/3449658980
Motivation and Context
Improved performance and compatibility. See release notes above.
Types of changes
Checklist