Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] fix typing in get_full_page_screenshot_as_png #11163

Conversation

eNcacz
Copy link
Contributor

@eNcacz eNcacz commented Oct 24, 2022

Description

Fix for issue 11157

Motivation and Context

Wrong type for get_full_page_screenshot_as_png method causes false positive mypy findings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Type for returned value was changed from str to bytes to reflect the reality.

@titusfortner titusfortner merged commit ce88314 into SeleniumHQ:trunk Oct 24, 2022
@titusfortner
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants