[java] removed the broken escape #11110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quote marks were replaced by identical quote marks to escape them. This is an unnecessary operation, as the resulting string will be identical to the original string.
Codecov ReportBase: 52.31% // Head: 52.31% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## trunk #11110 +/- ##
=======================================
Coverage 52.31% 52.31%
=======================================
Files 82 82
Lines 5503 5503
Branches 198 198
=======================================
Hits 2879 2879
Misses 2426 2426
Partials 198 198 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The escaping of javascript was broken, it replaced a quote with a identical quote to escape it.
I guess the original author tried to add a backslash to escape the quote, but the magic behind the
String.replaceAllswallows the backslash. This will lead to a identical string before and after escaping the string.(To get the assumed behavior it should have been
script.replaceAll("\"", "\\\\\"")and notscript.replaceAll("\"", "\\\""))The
String.replaceAllcall was dropped in this PR to get rid of this confusing code.Motivation and Context
Overhead processing the RegEx / get rid of confusing code.
Types of changes
Checklist