Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] close the CDP connection on quit for FF #11109

Merged
merged 1 commit into from
Oct 12, 2022
Merged

[java] close the CDP connection on quit for FF #11109

merged 1 commit into from
Oct 12, 2022

Conversation

joerg1985
Copy link
Member

Description

The FirefoxDriver did not close the CDP connection on quit like the ChromiumDriver does.

Motivation and Context

It is desirable to gracefully close all opened connections.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joerg1985
close the CDP connection on quit for FF
9fe88b7 
The FirefoxDriver did not close the CDP connection on quit like the
ChromiumDriver does.
@joerg1985 joerg1985 changed the title close the CDP connection on quit for FF [java] close the CDP connection on quit for FF Oct 11, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

diemol
diemol approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joerg1985!

@diemol diemol merged commit 0cceb8a into SeleniumHQ:trunk Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Temporary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joerg1985 @diemol @titusfortner