Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to build Selenium Manager in CI (for Windows, Linux, and macOS) #11102

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR creates a GH Actions workflow to build Selenium Manager for the three main operating systems: Windows, Linux, and macOS. This workflow is manually triggered. The objective is to use the generated binaries (attached as artifacts at the end of the workflow execution) in the future releases of Selenium Manager.

Motivation and Context

This PR is part of the development of Selenium Manager M1. Since it is non-trivial to cross-compile Rust (e.g., generate a Windows binary from a macOS machine), we can use the virtual environments of GH Actions (windows-latest, ubuntu-latest, and macos-latest) to that aim.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner
Copy link
Member

The goal is to just generate the binaries? Where are they stored? I thought upload-artifact just allowed things to be used by other actions?

@bonigarcia
Copy link
Member Author

Yes, the goal is just to generate the Selenium Manager binaries, for Windows, Linux, and macOS. The binaries can be downloaded from GH, in the workflow execution page. You can see an example here:

https://github.com/bonigarcia/rust-examples/actions/runs/3220624172

We can manually get these binaries and include then in the Selenium releases, if finally we decide to do it that way.

@titusfortner
Copy link
Member

Though, downside is github doesn't support M1, yet.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bonigarcia!

@diemol diemol merged commit d8ffd13 into trunk Oct 11, 2022
@diemol diemol deleted the manager-build branch October 11, 2022 10:04
@diemol diemol added the hacktoberfest-accepted Temporary label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants