fix: Check that a port truly is free before using it

[Artur-]

Description

If for instance 0.0.0.0:12345 is bound then running chromedriver with '--port=12345 --allowed-ips=1.2.3.4' fails with address already in use. If ::1 port 1234 is in used, chromedriver with '--port=12345' fails

Motivation and Context

Chromedriver fails to start in many cases with [SEVERE]: bind() failed: Address already in use (48)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[CLAassistant]

All committers have signed the CLA.

[codecov-commenter]

Codecov Report

Base: 55.49% // Head: 55.49% // No change to project coverage 👍

Coverage data is based on head (214ccb7) compared to base (6479063).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #11085   +/-   ##
=======================================
  Coverage   55.49%   55.49%           
=======================================
  Files          82       82           
  Lines        5503     5503           
  Branches      278      278           
=======================================
  Hits         3054     3054           
  Misses       2171     2171           
  Partials      278      278           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[diemol]

Thank you, @Artur-!

[diemol]

@Artur- I am reverting the isFree("::1", port), this is breaking in Linux and some macOS machines.

[Artur-]

Is the problem that the machines do not have ipv6 support on or something else?

[diemol]

I would say yes, however I didn't have enough time to check it

[Artur-]

Ok, I assumed } catch (Exception e) { would have caught that

[Artur-]

Ah, but that returns false. So then every port will be in use and nothing free..

[diemol]

Ah, but that returns false. So then every port will be in use and nothing free..

Exactly, that is the issue, so we do not know if ipv6 is available or the port being busy.