[java] pick random port outside of well-known ranges of ephemeral ports #10990
Conversation
Let port prober choose from a safe range of ephemeral ports that explicitly exclude the well-known range of ephemeral ports used by the OS for port allocation as was done in Selenium v3. Keep fallback to IANA port range in case range of ephemeral ports is too low (less than 5k). Fixes SeleniumHQ#10974
|
|
|
I followed the steps described in README to build and test Selenium Java but had to abort the build process as it eats all of my free disk space. I would really appreciate if someone else could take over that part. |
symonk
changed the title
Codecov ReportBase: 52.31% // Head: 52.31% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## trunk #10990 +/- ##
=======================================
Coverage 52.31% 52.31%
=======================================
Files 82 82
Lines 5503 5503
Branches 198 198
=======================================
Hits 2879 2879
Misses 2426 2426
Partials 198 198 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Related to #10974 |
|
I have gone through the changes and it looks fine on the surface. However, Simon and Diego will have a better idea about this area. I have requested them to help review it. |
|
bump |
|
Hi guys. Any news on this? |
|
SonarCloud Quality Gate failed. |
|
🥳 Thanks for merging, @diemol ! |
Description
Let port prober choose from a safe range of ephemeral ports that explicitly exclude the well-known range of ephemeral ports used by the OS for port allocation (as was done in Selenium v3) while keeping fallback to IANA port range in case range of ephemeral ports is too low (less than 5k).
Motivation and Context
Instead of choosing a random port within the well-known ranges of ephemeral ports, those ranges should be excluded in order to minimize probability of collisions with port allocations performed by OS.
Types of changes
Checklist