-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Remove deprecated methods that use capabilities in WebDrivers #10427
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #10427 +/- ##
==========================================
+ Coverage 46.56% 48.20% +1.64%
==========================================
Files 86 86
Lines 5863 5570 -293
Branches 278 279 +1
==========================================
- Hits 2730 2685 -45
+ Misses 2855 2606 -249
- Partials 278 279 +1
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed!
|
fwiw I'm 👎 on this for now. I'd like for us to keep it deprecated, but continue to support using |
Well, I take this back. Looks like Capabilities were only deprecated for local drivers, not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this for Selenium 4.3
SonarCloud Quality Gate failed. |
…eleniumHQ#10427) * [java] Remove deprecated methods that use capabilities in WebDrivers Co-authored-by: Diego Molina <[email protected]>
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Remove deprecated methods that use capabilities in WebDrivers
Motivation and Context
It is recommended to use browser-specific options instead of capabilities. Hence, the WebDriver implementation constructors that use capabilities are deprecated. These have been deprecated for multiple versions.
Types of changes
Checklist