Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: extend interface HttpHandler with executeAsync method #14403

Closed
joerg1985 opened this issue Aug 16, 2024 · 7 comments
Closed
Labels
C-grid help wanted Issues looking for contributions I-enhancement

Comments

@joerg1985
Copy link
Member

joerg1985 commented Aug 16, 2024

Feature and motivation

This will allow to write none blocking methods in the backend without spawning threads in these places and handle this, e.g. Node.touchSessionAsync.

Usage example

Everytime a websocket message is proxied between the node and the driver the implementation waits until the session map has performed the touch to keep the session alive. This delay could be removed by touching the session async.

When BiDi is in place and alot of websocket message are proxied this might get a bottleneck in interception of network traffic or other frequent browser events.

@joerg1985
Copy link
Member Author

I could create a PR for this in case you think this makes sense, but i do not want to waste time on it in case you think this is not needed.

Copy link

@joerg1985, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol diemol added C-grid help wanted Issues looking for contributions and removed needs-triaging labels Aug 19, 2024
@diemol
Copy link
Member

diemol commented Aug 19, 2024

Thank you, @joerg1985. This makes sense.

Copy link

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

@joerg1985
Copy link
Member Author

I have create a PR for this with one change, i have extended the HttpClient interface.
The HttpHandler is used in a lot of areas that do not benefit from this change.

@joerg1985
Copy link
Member Author

The HttpClient has been extended with the new method.

Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-grid help wanted Issues looking for contributions I-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants