[py] put the fix in the wrong place

SeleniumHQ · Dec 2, 2022 · d03ad02 · d03ad02
1 parent 01a47b4
commit d03ad02
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/py/selenium/webdriver/common/selenium_manager.py b/py/selenium/webdriver/common/selenium_manager.py
@@ -67,6 +67,9 @@ def driver_location(self, browser: str) -> str:
         if browser not in allowed:
             raise SeleniumManagerException(f"{browser} is not a valid browser.  Choose one of: {allowed}")
 
+        if browser == 'ie':
+            browser = 'iexplorer'
+
         binary, flag, browser = str(self.get_binary()), "--browser", browser
         result = self.run((binary, flag, browser))
         executable = result.split("\t")[-1].strip()

diff --git a/py/selenium/webdriver/common/service.py b/py/selenium/webdriver/common/service.py
@@ -92,8 +92,7 @@ def start(self) -> None:
             if "executable needs to be in PATH" in err.msg:
                 logger.debug("driver not found in PATH, trying Selenium Manager")
                 browser = self.__class__.__module__.split(".")[-2]
-                if browser == 'ie':
-                    browser = 'iexplorer'
+
                 try:
                     path = SeleniumManager().driver_location(browser)
                 except WebDriverException as new_err: