-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Support switch binary Chrome/Chromium in Node/Standalone all browsers image #2946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…browsers image Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
[skip ci] Signed-off-by: Viet Nguyen Duc <[email protected]>
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Add support for switching browser binaries via environment variable
Improve documentation for environment variables with examples
Enhance all-browsers image configuration flexibility
Update README with single image architecture details
Diagram Walkthrough
File Walkthrough
ENV_VARIABLES.md
Enhanced environment variable documentationENV_VARIABLES.md
SE_BROWSER_BINARY_LOCATIONwith usageexamples
SE_NODE_CONTAINER_NAMEand stereotypevariables
README.md
All-browsers image documentation and architecture detailsREADME.md
description.yaml
Environment variable descriptions enhancementscripts/generate_list_env_vars/description.yaml
variables
generate_config
Dynamic browser binary path configurationNodeBase/generate_config
substitution
envsubstfor dynamic pathresolution
SE_BROWSER_BINARY_LOCATIONtoBINARY_LOCATIONDockerfile
Chrome binary path environment variable supportNodeChrome/Dockerfile
SE_BROWSER_BINARY_LOCATIONenvironment variable
/usr/bin/google-chromeDockerfile
Chromium binary path environment variable supportNodeChromium/Dockerfile
SE_BROWSER_BINARY_LOCATIONenvironment variable
/usr/bin/chromiumDockerfile
Edge binary path environment variable supportNodeEdge/Dockerfile
SE_BROWSER_BINARY_LOCATIONenvironment variable
/usr/bin/microsoft-edgeDockerfile
Firefox binary path environment variable supportNodeFirefox/Dockerfile
SE_BROWSER_BINARY_LOCATIONenvironment variable
/usr/bin/firefox