Docker: Resolve default event bus port 4442 and 4443 in env var #2688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
In part of #2662
SE_EVENT_BUS_PUBLISH_PORT="4442"
SE_EVENT_BUS_SUBSCRIBE_PORT="4443"
these 2 env vars were added to Dockerfile instruction as default. So, command docker run or docker compose file no need to specify anymore if the default is being used.
Motivation and Context
Types of changes
Checklist
PR Type
enhancement, documentation
Description
Removed explicit event bus port environment variables from Docker Compose files.
Simplified Docker Compose configurations by relying on default values.
Updated documentation to reflect the removal of explicit port settings.
Improved maintainability by reducing redundancy in environment variables.
Changes walkthrough 📝
1 files
Removed explicit event bus port settings from examples.
12 files
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
5 files
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.
Removed explicit event bus port environment variables.