You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A simple change adding the missing securityContext fields to the initContainers so that they can be set for those along with the regular containers.
Motivation and Context
When security policies are enforced in a cluster that the default configuration does not comply with the pre-puller-* pods will not be allowed to start, even though securityContext is set.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
The command ["bash", "-c", "'true'"] has unnecessary single quotes around 'true' which may cause the command to fail. Should be ["bash", "-c", "true"] instead.
Remove the single quotes around 'true' in the command field. In Kubernetes/Helm, the command should be a plain string without quotes, as the single quotes will be interpreted literally.
Why: The single quotes around 'true' in the command field would be interpreted literally by Kubernetes, potentially causing command execution issues. This is a significant fix that affects container initialization functionality.
Thank you, @calendir. I merged to include it in next chart deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
A simple change adding the missing
securityContextfields to theinitContainersso that they can be set for those along with the regular containers.Motivation and Context
When security policies are enforced in a cluster that the default configuration does not comply with the
pre-puller-*pods will not be allowed to start, even thoughsecurityContextis set.Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
Added
securityContextsupport forinitContainersin Helm chart.Ensured compatibility with enforced cluster security policies.
Updated
pre-puller-*pods to includesecurityContext.Changes walkthrough 📝
_helpers.tpl
Add `securityContext` to `initContainers` and containerscharts/selenium-grid/templates/_helpers.tpl
securityContextfield fornodecontainers.securityContextfield forrecordercontainers.securityContextis configurable forinitContainers.