Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): videoRecorder getting scripts from external files #2095

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

feat(chart): videoRecorder getting scripts from external files

Motivation and Context

Update video recorder feature deployed on Kubernetes able to work seamlessly with recently changes:

  • SessionId can be fetched when Grid components enable HTTPS.
  • Video recorder and uploader can shut down gracefully when Autoscaling is enabled with scalingType: job. Before it was changing pod status to 2/3 NotReady instead of Completed when Node was drained by SE_DRAIN_AFTER_SESSION_COUNT: 1
  • Shell scripts implemented for the recorder and uploader are getting from external files which allow users can modify, or replace them more easily.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VietND96 VietND96 self-assigned this Jan 19, 2024
@VietND96 VietND96 force-pushed the trunk branch 4 times, most recently from 9c77204 to c5833d3 Compare January 19, 2024 01:21
@VietND96 VietND96 merged commit e521d99 into SeleniumHQ:trunk Jan 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant