Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(chart): CI Bot bump chart version along with new deploy image version #2028

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

CI Bot bump chart version along with new deploy image version

Motivation and Context

When a commit event contains [deploy], CI Bot will make a commit to update tag, docs, and files, but Chart.yaml is excluded as of now.
With this update, the flow will be: commit event contains [deploy] -> CI Bot committed and pushed the change (include Chart.yaml) -> Trigger event push on path charts/selenium-grid/Chart.yaml for the workflow to release chart.
The chart version increment follows semantic versioning in the next tag. For example:

./update_tag_in_docs_and_files.sh 4.15.0-20231122 4.15.0-20231128
Chart.yaml > version: 0.25.1 -> 0.25.2
./update_tag_in_docs_and_files.sh 4.15.0-20231122 4.16.0-20231201
Chart.yaml > version: 0.25.1 -> 0.26.0
./update_tag_in_docs_and_files.sh 4.15.0-20231122 5.1.0-20240404
Chart.yaml > version: 0.25.1 -> 1.0.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

[skip ci]
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

@diemol diemol merged commit bbef734 into SeleniumHQ:trunk Nov 27, 2023
@VietND96 VietND96 deleted the helm-chart branch November 27, 2023 12:00
@VietND96 VietND96 linked an issue Nov 30, 2023 that may be closed by this pull request
@VietND96 VietND96 changed the title feat: CI Bot bump chart version along with new deploy image version build(chart): CI Bot bump chart version along with new deploy image version Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Charts maintainer needed
2 participants