-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom loaders for function notation #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangonz
changed the title
Add custom loaders for function notation
WIP : Add custom loaders for function notation
Mar 31, 2021
adriangonz
force-pushed
the
load-method
branch
2 times, most recently
from
April 6, 2021 16:21
1b19bde
to
78d3f15
Compare
adriangonz
changed the title
WIP : Add custom loaders for function notation
Add custom loaders for function notation
Apr 8, 2021
ukclivecox
reviewed
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Changelog
Model
toBaseModel
cls
pointer and simplify how custom functions are bound to the classloadmethod
decorator when using function notationcontext
field to share object instances between different methods (useful when using the function notation)TODO
Call(to be done on issue Save class definition (instead of instance) #91)__init__
in MLServer for decorated classescontext
field before saving artifact