Request logger with cloud events (compatible with Seldon Deploy install) #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axsaucedo
commented
Jun 24, 2021
| tempo_wrapper = TempoContextWrapper(payload_context, insights_wrapper) | ||
| tempo_context.set(tempo_wrapper) | ||
|
|
||
| response_dict = self._model.request(request_dict) | ||
| if self._is_coroutine: | ||
| response_dict = await response_dict # type: ignore | ||
|
|
||
| # TODO: Ensure model_version is added by mlserver | ||
| response_dict["model_version"] = "NOTIMPLEMENTED" |
There was a problem hiding this comment.
This needs to be replaced for self.version as it's mlserver class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension to support request logger for seldon deploy, with nuances around current limitations that should be explored further, but provides base functionality to make it work with request logger screen, and that could work with outlier / drift detectors + metrics servers, load testers, etc
Requests Screen
Model screen