Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build operator image when running e2e locally #1172

Merged
merged 3 commits into from
Dec 4, 2019

Conversation

ryandawsonuk
Copy link
Contributor

fixes #1171

@ryandawsonuk
Copy link
Contributor Author

/ok-to-test
/test integration

@ryandawsonuk
Copy link
Contributor Author

@ryandawsonuk
Copy link
Contributor Author

/test integration

@ryandawsonuk
Copy link
Contributor Author

@ryandawsonuk ryandawsonuk changed the title build operator image when running e2e locally WIP: build operator image when running e2e locally Dec 2, 2019
@ryandawsonuk
Copy link
Contributor Author

/test integration

1 similar comment
@ryandawsonuk
Copy link
Contributor Author

/test integration

@ryandawsonuk
Copy link
Contributor Author

/retest

@ryandawsonuk
Copy link
Contributor Author

This time around some of the s2i tests failed. It looks like kind itself in the cluster had trouble as well as the seldon controller that led to some failures in the s2i tests. Most of the tests actually passed and even most of the s2i tests. Looks like a resource issue this time.

@ryandawsonuk
Copy link
Contributor Author

/test integration

@ryandawsonuk
Copy link
Contributor Author

Ok integration tests passed this time.
/approve
/lgtm

@seldondev
Copy link
Collaborator

@ryandawsonuk: you cannot LGTM your own PR.

In response to this:

Ok integration tests passed this time.
/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ryandawsonuk ryandawsonuk changed the title WIP: build operator image when running e2e locally build operator image when running e2e locally Dec 3, 2019
@ryandawsonuk
Copy link
Contributor Author

ryandawsonuk commented Dec 3, 2019

/hold
Actually not so clear. The e2e test status shows as green:
image
But nothing has been logged for this PR today

Could just be another test infra problem

@ryandawsonuk ryandawsonuk changed the title build operator image when running e2e locally WIP: build operator image when running e2e locally Dec 3, 2019
@ryandawsonuk
Copy link
Contributor Author

/test integration

@ryandawsonuk
Copy link
Contributor Author

The tests are passing as revealed by kubectl logs seldonio-seldon-core-pr-1172-in-464fg-15-end-to-end-pd67v-pod-238dee step-test-end-to-end and jx get activities | grep 1172 but nothing seems to be getting logged anymore.

jx get storage still points at gh-pages. Could be something like jenkins-x/jx#2877 but not sure how to find where it fails.

@ryandawsonuk
Copy link
Contributor Author

Just took a backup of the gh-pages branch called gh-pages-backup1219 and deleted the gh-pages branch. Will see what happens on a new run now.

@ryandawsonuk
Copy link
Contributor Author

/test integration

@ryandawsonuk
Copy link
Contributor Author

ryandawsonuk commented Dec 4, 2019

Ok that didn't help, it didn't recreate the branch. I've now recreated it manually but am not making any progress with why it's not recording logs.

@ryandawsonuk
Copy link
Contributor Author

On suggestion from the jx slack I've restarted jenkins-x-controllerbuild.

/test integration

@ryandawsonuk
Copy link
Contributor Author

I see things running now through jx get build logs. Still nothing going to gh-pages though.

@ryandawsonuk
Copy link
Contributor Author

ryandawsonuk commented Dec 4, 2019

New idea is to try doing a jx boot and then a jx upgrade platform

@ryandawsonuk
Copy link
Contributor Author

jx upgrade boot fails with:

b83cffd859879e54e9973fdb7b9da7617eb2c998 - feat: add ability to configure exposer
381d34686f85375acc0961b688c6644d41225a05 - Check .Requirements.cluster has a key project in external-dns
6b99c30b1d6ded3336646be32f6d3059cd74e5ef - fix: added velero configuration for iks
164d64440f548142342a3a898a5243bd81cd5490 - fix: disable the build and plank microservices of prow
a8c773903c0a96e036eb7bfab8ff97a8b3acb358 - fix: allow bucketrepo to be used as a repository
46096acecabb9ea86d2aa1fd21a55efb99ab7314 - fix: disable chart museum
1fa391fc6324b52da1a066b0331a4a4a092b987d - fix: use of Requirements.repository
84ba05b583dd6eea3a31013dd6a9861626727177 - fix: Add verify-fmt and fmt, fail PR if not formatted
error: failed to update boot configuration: failed to cherry pick upgrade commits: cherry-picking 6065e8417e538cc4e53d719feb3b0337edb76ea1: git output: The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch de04426a-0d57-4565-ad35-377638eb9c47
You are currently cherry-picking commit 6065e84.

nothing to commit, working tree clean: failed to run 'git cherry-pick 6065e8417e538cc4e53d719feb3b0337edb76ea1 --strategy=recursive -X theirs' command in directory '/tmp/803628616', output: 'The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch de04426a-0d57-4565-ad35-377638eb9c47
You are currently cherry-picking commit 6065e84.

Seem to be hitting jenkins-x/jx#5582

Apparently there have been a range of issues around this recently - jenkins-x/jx#6132. Looks like they're on-going

@ryandawsonuk
Copy link
Contributor Author

Did manage to run jx upgrade platform and now there are new logs !

@ryandawsonuk ryandawsonuk changed the title WIP: build operator image when running e2e locally build operator image when running e2e locally Dec 4, 2019
@ryandawsonuk
Copy link
Contributor Author

/approve
/lgtm

@seldondev
Copy link
Collaborator

@ryandawsonuk: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ryandawsonuk
Copy link
Contributor Author

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 6a90ef7 into SeldonIO:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local e2e don't build operator image
2 participants