Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FingersCrossedHandler fix passthruLevel checking (Fixes #1800) #1801

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

BrianMwit
Copy link
Contributor

@BrianMwit BrianMwit commented Apr 6, 2023

Fixes #1800

@BrianMwit BrianMwit marked this pull request as ready for review April 6, 2023 14:42
@kkreft
Copy link

kkreft commented Jun 13, 2023

@stof Do we need anything else to merge it and release the fix? I'm kinda interested in that particular change and happy to help 😄

BTW thx for maintaining this ❤️

@kkreft
Copy link

kkreft commented Jun 16, 2023

@Seldaek Hi, same question as above - what can I do to help make this change merged? 😄

@stof
Copy link
Contributor

stof commented Jun 19, 2023

@kkreft we need to wait for @Seldaek to see this PR.
I'm helping reviewing PRs on that repository but I don't have any collaborator access on it, so I cannot merge anything myself.

@Seldaek Seldaek added this to the 3.x milestone Jun 20, 2023
@Seldaek Seldaek added the Bug label Jun 20, 2023
@Seldaek
Copy link
Owner

Seldaek commented Jun 20, 2023

Sorry for the delay everyone, it's been busy times here :) Thanks for the fix tho, I'll try and get a release out soon.

@Seldaek Seldaek merged commit 06276fc into Seldaek:main Jun 20, 2023
@BrianMwit BrianMwit deleted the FingersCrossedHandler branch June 20, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FingersCrossedHandler Does not check passthruLevel properly
10 participants