Added a -q option to suppress output if no errors, and show filename on error #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinlindhe
changed the title
before: $ bin/jsonlint bad.json bad.json: Parse error on line 2: ...th trailing comma",} ----------------------^ Expected: 'STRING' - It appears you have an extra trailing comma after: $ bin/jsonlint bad.json bad.json: Parse error on line 2: ...th trailing comma",} ---------------------^
| if ($contents = file_get_contents('php://stdin')) { | ||
| lint($contents); | ||
| } | ||
|
|
||
| echo 'Usage: jsonlint file'.PHP_EOL; | ||
| echo 'Usage: jsonlint file [options]'.PHP_EOL; |
There was a problem hiding this comment.
the usage should display the available options too
There was a problem hiding this comment.
Thanks for feedback. While looking at how to fix this, i realized the code path would only output usage info after stdin have been read. (this is the same in the original code).
So instead i added other options (-h, --help) to show the usage information in commit
https://github.com/martinlindhe/jsonlint/commit/b46b0a1d41c03603e3c66e53cf03b3a96a791d5c
fixing broken code path where usage info was displayed
only if file_get_contents('php://stdin') failed, which is
not possible
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intend to use jsonlint as part of build process and would like to supress unnessecary output, so I added a -q option to make it quiet on successful validation.
Also added name of the file when error was found