Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller tests #62

Merged
merged 28 commits into from
Dec 22, 2019
Merged

Controller tests #62

merged 28 commits into from
Dec 22, 2019

Conversation

Segelzwerg
Copy link
Owner

Add test coverage for spring controller.

Marcel added 27 commits December 19, 2019 13:56
due to codecov no recognizing these tests

This reverts commit c19f341.
Revert "UPDATE: slow tag for controller tests"

This reverts commit b4e00ab.
Revert "ADD: gradle task for slow tests"

This reverts commit f22c8e3.
Revert "UPDATE: slow test task configure for gradle check task"

This reverts commit 34eb8f6.
Revert "UPDATE: gradle jacoco task to depend on test tasks"

This reverts commit b04f6e2.
Revert "TRY: integrate slow tests"

This reverts commit 586fc81.
UPDATE: make heatmapservice not final
UPDATE: generate method to throw exception
UPDATE: exception behavior
@Segelzwerg Segelzwerg added the tests New Unit or Integrationtests label Dec 21, 2019
@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #62 into master will increase coverage by 15.73%.
The diff coverage is 80%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #62       +/-   ##
=============================================
+ Coverage     67.85%   83.59%   +15.73%     
- Complexity      104      129       +25     
=============================================
  Files            22       23        +1     
  Lines           252      256        +4     
  Branches         11       12        +1     
=============================================
+ Hits            171      214       +43     
+ Misses           73       34       -39     
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
...g/sporttooolbox/web/heatmap/HeatMapController.java 100% <100%> (+100%) 8 <5> (+8) ⬆️
.../java/segelzwerg/sporttooolbox/web/Translator.java 100% <100%> (ø) 4 <1> (+1) ⬆️
...ava/segelzwerg/sporttooolbox/web/ImageService.java 25% <25%> (ø) 1 <1> (?)
...elzwerg/sporttooolbox/IUnits/KilometerPerHour.java 92.3% <0%> (+7.69%) 9% <0%> (+1%) ⬆️
...lzwerg/sporttooolbox/web/speed/SpeedPresenter.java 100% <0%> (+11.11%) 5% <0%> (+1%) ⬆️
.../sporttooolbox/IUnits/MinutesPerHundredMeters.java 75% <0%> (+12.5%) 4% <0%> (+1%) ⬆️
...werg/sporttooolbox/IUnits/MinutesPerKilometer.java 87.5% <0%> (+12.5%) 5% <0%> (+1%) ⬆️
...gelzwerg/sporttooolbox/web/pace/PacePresenter.java 100% <0%> (+14.28%) 4% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff49f6d...80dc6a6. Read the comment docs.

@Segelzwerg Segelzwerg merged commit 966ea70 into master Dec 22, 2019
@Segelzwerg Segelzwerg deleted the controller_tests branch December 22, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests New Unit or Integrationtests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant