Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip null properties on validation / transformation #3346

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/validation/validation.pipe.ts
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ export class ValidationPipe extends BaseValidationPipe {
constructor(private readonly moduleRef: ModuleRef) {
super({
transform: true,
skipMissingProperties: true,
skipUndefinedProperties: true,
exceptionFactory: (es) => new ValidationException(es),
});
}

Unchanged files with check annotations Beta

scriptureReferencesOverride: ScriptureRange.randomList(),
});
const result = await app.graphql.query(

Check failure on line 550 in test/product.e2e-spec.ts

GitHub Actions / E2E Tests (neo4j 2/6)

Product e2e › update DerivativeScriptureProduct with scriptureReferencesOverride which is null

[Validation, Client]: Input validation failed at Object.<anonymous> (test/product.e2e-spec.ts:550:20)
gql`
mutation updateDerivativeScriptureProduct(
$input: UpdateDerivativeScriptureProduct!