Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.4 support #1

Closed
remicollet opened this issue May 27, 2019 · 3 comments · Fixed by #2
Closed

PHP 7.4 support #1

remicollet opened this issue May 27, 2019 · 3 comments · Fixed by #2

Comments

@remicollet
Copy link

For now, build fails

/dev/shm/BUILD/php74-php-pecl-seasclick-0.1.0/NTS/SeasClick.cpp:119:30: error: 'ZEND_ACC_IMPLICIT_PUBLIC' was not declared in this scope
     SeasClick_ce->ce_flags = ZEND_ACC_IMPLICIT_PUBLIC;
                              ^~~~~~~~~~~~~~~~~~~~~~~~
@remicollet
Copy link
Author

From upgrading.internals

- ZEND_ACC_IMPLICIT_PUBLIC is removed (it was used only for reflection)

wujunze added a commit that referenced this issue May 28, 2019
@wujunze
PHP 7.4 support
fe089ab 
PHP 7.4 support
fix: #1
@wujunze wujunze mentioned this issue May 28, 2019
Merged
@aiwhj aiwhj closed this as completed in #2 Jun 6, 2019
@remicollet
Copy link
Author

Thanks

@morriszhao
Copy link

pecl 上的还没改呢
不支持 php7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PHP 7.4 support SeasX/SeasClick
2 participants
@remicollet @morriszhao