Hashable value #598
Merged
Hashable value #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyt2y3
force-pushed
the
hashable-value
branch
2 times, most recently
from
62a4fe5
to
8a7e3aa
Compare
ikrivosheev
approved these changes
Feb 7, 2023
4 tasks
🎉 Released In 0.29.0 🎉Your participation is what makes us unique; your adoption is what drives us forward. |
🎉 Released In 0.29.1 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SeaQL/sea-orm#1254
I have considered different implementations, and using a derive macro seems to be the easiest to maintain.
However, there is a catch when this feature is enabled: NaN == NaN, which contradicts Rust's built-in implementation of NaN != NaN