Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redefine type with DbBackEnd,prevent arbitrary invocation #966

Closed
wants to merge 0 commits into from
Closed

Reduce redefine type with DbBackEnd,prevent arbitrary invocation #966

wants to merge 0 commits into from

Conversation

baoyachi
Copy link
Contributor

Unified into one name to: DatabaseBackend,

@baoyachi baoyachi changed the title Reduce redefine type with DbBackEnd,prevent arbitrary invocation of e… Reduce redefine type with DbBackEnd,prevent arbitrary invocation Aug 12, 2022
@baoyachi
Copy link
Contributor Author

baoyachi commented Aug 12, 2022

@billy1624 It's cause by build error by #965 .

@@ -1,7 +1,7 @@
use pretty_assertions::assert_eq;
use sea_orm::{
ColumnTrait, ColumnType, ConnectionTrait, Database, DatabaseBackend, DatabaseConnection,
DbBackend, DbConn, DbErr, EntityTrait, ExecResult, Iterable, Schema, Statement,
ColumnTrait, ColumnType, ConnectionTrait, Database, DatabaseConnection, DbBackend, DbBackend,
Copy link

@HighOrderLogic HighOrderLogic Aug 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ColumnTrait, ColumnType, ConnectionTrait, Database, DatabaseConnection, DbBackend, DbBackend,
ColumnTrait, ColumnType, ConnectionTrait, Database, DatabaseConnection, DbBackend

@baoyachi baoyachi closed this Aug 15, 2022
@baoyachi baoyachi deleted the merge_type_name_with_DbBackend branch August 15, 2022 03:08
@billy1624
Copy link
Member

Oh... okay loll

@billy1624 billy1624 linked an issue Aug 25, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codegen] Struct / enum derive PartialEq should also derive Eq
3 participants