Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sea-strum lib back to strum #361

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Rename sea-strum lib back to strum #361

merged 2 commits into from
Dec 25, 2021

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Dec 7, 2021 •
edited
Loading

PR Info

@billy1624 billy1624 self-assigned this Dec 7, 2021
@billy1624 billy1624 marked this pull request as ready for review December 7, 2021 09:22
@tyt2y3
Copy link
Member

tyt2y3 commented Dec 7, 2021

Well this confuses me. So the crate name is still sea-strum but the namespace is strum?

@billy1624
Copy link
Member Author

billy1624 commented Dec 7, 2021 •
edited
Loading

Well this confuses me. So the crate name is still sea-strum but the namespace is strum?

Correct. I guess this would be much easier for us to fetch upstream changes? Also, allowing the test cases to be executed.

@Sytten
Copy link
Contributor

Sytten commented Dec 7, 2021

Agreed on that, much easier to deal with upstream!

@tyt2y3 tyt2y3 merged commit c31227a into master Dec 25, 2021
@tyt2y3 tyt2y3 deleted the pulls/361 branch December 25, 2021 10:30
@renovate renovate bot mentioned this pull request Apr 25, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billy1624 @tyt2y3 @Sytten