API DEMO: find_with_linked
#1725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkmmon
suggested changes
Jun 29, 2023
Comment on lines
+767
to
+771
| "INNER JOIN `cakes_bakers` AS `r0` ON `r0`.`baker_id` = `baker`.`id`", | ||
| "INNER JOIN `cake` AS `r1` ON `r1`.`id` = `r0`.`cake_id`", | ||
| "INNER JOIN `lineitem` AS `r2` ON `r2`.`cake_id` = `r1`.`id`", | ||
| "INNER JOIN `order` AS `r3` ON `r3`.`id` = `r2`.`order_id`", | ||
| "INNER JOIN `customer` AS `r4` ON `r4`.`id` = `r3`.`customer_id`", |
There was a problem hiding this comment.
Should this be a inner join or a left join?
I found that other find_with/find_also functions use left join instead of inner join
There was a problem hiding this comment.
Yes, it should be LEFT JOIN
Comment on lines
+807
to
+820
| customer::Model { | ||
| id: 1, | ||
| name: "Kate".into(), | ||
| notes: Some("Loves cheese cake".into()), | ||
| }, | ||
| customer::Model { | ||
| id: 1, | ||
| name: "Kate".into(), | ||
| notes: Some("Loves cheese cake".into()), | ||
| }, | ||
| customer::Model { | ||
| id: 2, | ||
| name: "Kara".into(), | ||
| notes: Some("Loves all cakes".into()), |
There was a problem hiding this comment.
Not sure if the order of these matters or not, since they return in reverse order for my implementation
There was a problem hiding this comment.
Note that I have have ORDER BY expression
ORDER BY `baker`.`id` ASC| ), | ||
| ( | ||
| baker::Model { | ||
| id: 1, |
There was a problem hiding this comment.
I believe this should be a 2 instead of 1?
There was a problem hiding this comment.
Seems this is a follow up question of #1725 (comment)?
|
I will closed this PR. @darkmmon please file your PR :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info