-
-
Notifications
You must be signed in to change notification settings - Fork 568
#1696 fix #1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
#1696 fix #1702
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7b5cce4
Test suit load environment variable from env files
billy1624 0215d8d
Added expr() and exprs() for QuerySelect trait and Minor typo fix
darkmmon 8c3dfad
Merge remote-tracking branch 'sea-orm/master' into #1696-fix
darkmmon bd93088
fmt
darkmmon fa3c75a
Added doc testing for the new functions
darkmmon c45475f
Remove excess comment for doc test
darkmmon 3c000f8
Remove excess comment for doc test
darkmmon d0acc86
updated doc tests to make example more realistic
darkmmon 4272ad5
Merge remote-tracking branch 'darkmmon/#1696-fix' into #1696-fix
darkmmon 8e6d2d9
changed doc test again for more realistic query and added expr_as()
darkmmon 5e02231
aligned expr_as() alias input with column_as() input
darkmmon db06b62
update doc test for expr_as() according to previous changes
darkmmon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final change, we may well align it with
QuerySelect::column_as
method and take an alias ofI: IntoIdentity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hint: better update the example to supply an
&str
as the aliasThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!