Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SeaORM doesn't compile when "macros" flag is not set #249

Closed
tqwewe opened this issue Oct 15, 2021 · 2 comments
Closed

SeaORM doesn't compile when "macros" flag is not set #249

tqwewe opened this issue Oct 15, 2021 · 2 comments

Comments

@tqwewe
Copy link
Contributor

tqwewe commented Oct 15, 2021

SeaORM fails to compile when the "macros" flag is not set due to it being used in places such as tests_cfg and possibly other modules.
tyt2y3 added a commit that referenced this issue Oct 15, 2021
@tyt2y3
#249 Build with mock only
55dbdb7
tyt2y3 added a commit that referenced this issue Oct 15, 2021
@tyt2y3
#249 Build with mock + macros
8ce392b
@tyt2y3
Copy link
Member

tyt2y3 commented Oct 15, 2021 •
edited
Loading

Thank you for the report. It seems that it's hard enough to make the crate build without mock.
Since mock does not have any extra dependency, hopefully we can live with that for now.

tyt2y3 added a commit that referenced this issue Oct 20, 2021
@tyt2y3
#249 Demo of 'pure' crate depending on SeaORM
45f3548
@tyt2y3 tyt2y3 closed this as completed Oct 20, 2021
@tyt2y3
Copy link
Member

tyt2y3 commented Oct 20, 2021 •
edited
Loading

So the trick is to add mock as dev-dependencies, which is necessary for unit testing

@billy1624 billy1624 mentioned this issue Oct 30, 2021
Merged
arpancodes pushed a commit to arpancodes/sea-orm that referenced this issue Apr 8, 2022
@tyt2y3
Merge pull request SeaQL#249 from SeaQL/date-time-local
1751a27 
Add `Value::DateTimeLocal`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tyt2y3 @tqwewe