Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP7 Update #47

Closed
checkerschaf opened this issue Sep 15, 2017 · 3 comments
Closed

PHP7 Update #47

checkerschaf opened this issue Sep 15, 2017 · 3 comments

Comments

@checkerschaf
Copy link

Hey,

I'd recommend an update to PHP7 for maximum compatibility. Currently it's not working with many current releases of the most used frameworks.

Thanks!

@all4pages
Copy link

Yes with PHP7 no 3legged-oAuth

@all4pages
Copy link

all4pages commented Feb 1, 2018

I only got REQUEST and not APPLICATION in the Database when I tried to authentify the application.
I found a error in the file: Imocaster/Data/Mysql.php
In the function: saveApplicationToken()
-304: 'APPLICATION','".$sToken."','".$sSecret."','0000-00-00 00:00:00.000000','".$sUser."'
+304: 'APPLICATION','".$sToken."','".$sSecret."','1000-01-01 00:00:00.000000','".$sUser."'

The range from Datetime is 1000-01-01 00:00:00.000000 to 9999-12-31 23:59:59.999999
https://dev.mysql.com/doc/refman/5.7/en/datetime.html
So the mysqli_query will never return true and so the script: Imocaster/Data/Rest.php
with the funktion: registerAccess()
will always fall back from function registerApplication() to registerRequest()
and so you never get the application authentified.

I go on :-)

@christianbarkowsky
Copy link

christianbarkowsky commented Oct 17, 2018

successfully tested. Please fix the bug. 🙏

christianbarkowsky added a commit to christianbarkowsky/restapi-php-sdk that referenced this issue Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants