hwinfo: Update to version 8.32, fix checkver, refactor manifest #16366
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant Scoop
participant Manifest as hwinfo.json
participant ArchBlock
participant InstallerScript
User->>Scoop: scoop install hwinfo
Scoop->>Manifest: read version, bin, shortcuts, checkver, autoupdate
Manifest->>Scoop: provide top-level installer & per-arch pre_install
Scoop->>ArchBlock: select architecture block (64/32/arm64)
ArchBlock->>Scoop: run pre_install (arch-specific)
Scoop->>InstallerScript: run installer.script (top-level)
InstallerScript->>Scoop: create bin, shortcuts, perform install steps
Scoop->>User: installation complete (HWiNFO.exe, shortcut)
Note right of InstallerScript:#9fdfbf:green
Note right of InstallerScript: installer.script centralizes install logic
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. hwinfo
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/hwinfo.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (5)
bucket/hwinfo.json (5)
2-2: Version, license, and download URL updated correctly.Version bumped to 8.32 with matching download URL (hwi_832.zip) and hash. License modernized to structured object format with identifier and reference URL.
Also applies to: 5-10
13-28: Architecture-specific pre_install scripts correctly target relevant files.Each architecture branch appropriately removes irrelevant binaries (32, 64, ARM) and renames architecture-specific executables by stripping version/architecture suffixes (e.g.,
hwinfo64.exe→hwinfo.exe). The rename patterns align with the unifiedbin: "HWiNFO.exe"declaration at line 41.
41-47: Top-level bin and shortcuts unified correctly.Consolidating architecture-specific bin/shortcuts into a single top-level declaration (pointing to
HWiNFO.exe) is clean after the pre_install scripts rename executables to a common name.
48-52: pre_uninstall mirrors installer logic symmetrically.License key files are backed up and persist data is unlinked during uninstall, mirroring the installer's creation and linking of INI and key files. Consistent use of architecture-based INI naming.
57-59: No action required — autoupdate URL formula is correct.For version "8.32", Scoop parses it as $majorVersion = "8" and $minorVersion = "32", so the placeholder expansion
hwi_$majorVersion$minorVersion.zipcorrectly produceshwi_832.zipas intended. The code is working as expected.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
bucket/hwinfo.json (1)
48-51: Duplicate: unlink_persist_data also uses incorrect syntax.Line 51's
unlink_persist_data @{ persist = "$setting_name" } $dirhas the same issue as line 37—passing a hashtable instead of the manifest object. Both function calls must be corrected together.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/hwinfo.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/hwinfo.json (4)
2-2: Version, license, and URL updates look correct.The manifest now targets v8.32 with the updated download URL and hash. The license structure follows Scoop's object format, improving metadata clarity.
Also applies to: 5-10
13-29: Architecture-specific pre_install scripts are well-structured.Each architecture correctly filters and removes irrelevant binaries, then normalizes the naming of the active architecture's executable. The PowerShell logic is sound.
41-47: Top-level bin and shortcuts consolidation is clean.By normalizing architecture-specific executables to
HWiNFO.exevia the pre_install scripts, the unified bin/shortcuts declaration improves maintainability without redundancy.
57-59: Autoupdate URL template is correctly formatted.The version templating
$majorVersion$minorVersioncorrectly maps to the download pattern (e.g., 8.32 → hwi_832.zip). This will work once checkver is fixed to properly detect new versions.
|
/verify |
|
All changes look good. Wait for review from human collaborators. hwinfo
|
1 participant
Summary
This PR updates the
hwinfomanifest to version 8.32 and refactors its structure for better maintainability and compatibility across architectures.Related Issue
Changes
8.32and adjusted download URL and SHA256 hash.licensefield with reference URL.pre_installlogic for each architecture:64.32.persistentries with dynamic logic in theinstallerscript:HWiNFO64.INI,HWiNFO32.INI, orHWiNFO_ARM64.INI).*_KEY.txt) between$persist_dirand$dir.binandshortcutsdefinitions to a single consistent executable name:HWiNFO.exe.checkverandautoupdaterules to match new version and URL patterns.Testing
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
New Features
Refactor