Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update electerm to be portable #12175

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Update electerm to be portable #12175

wants to merge 11 commits into from

Conversation

muxinxy
Copy link
Contributor

@muxinxy muxinxy commented Nov 5, 2023

Update electerm to be portable, add persist directory and rename program name.

Closes #XXXX

Relates to #XXXX

@jasongodev
Copy link
Contributor

/verify

@github-actions GitHub Actions
Copy link
Contributor

Your changes do not pass checks.

electerm

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@tech189
Copy link
Member

tech189 commented Nov 25, 2023

Settings and other data is currently stored in AppData\Roaming\electerm so if we switch to the portable version, this will be lost. Could you add a pre_install function similar to bitwarden.json's that copies the relevant data to the electerm folder that gets persisted?

@muxinxy
Copy link
Contributor Author

muxinxy commented Nov 26, 2023

Settings and other data is currently stored in AppData\Roaming\electerm so if we switch to the portable version, this will be lost. Could you add a pre_install function similar to bitwarden.json's that copies the relevant data to the electerm folder that gets persisted?

Added "pre_install".

@jasongodev
Copy link
Contributor

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

electerm

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@rasa
Copy link
Member

rasa commented Dec 29, 2024

/verify

@github-actions GitHub Actions
Copy link
Contributor

Your changes do not pass checks.

electerm

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@rasa
Copy link
Member

rasa commented Dec 29, 2024

@muxinxy Merge conflict and checkver failure. Please review. Thx!

@muxinxy
Copy link
Contributor Author

muxinxy commented Jan 1, 2025

@muxinxy Merge conflict and checkver failure. Please review. Thx!

Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
manifest-fix-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muxinxy @jasongodev @tech189 @rasa