Ss 643 make an option to edit account details #235

anondo1969 · 2024-10-07T14:26:48Z

Status

Draft

Description

SS 643

Types of changes

new feature

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

This pull request is against develop branch (not applicable for hotfixes)
I have included a link to the issue on GitHub or JIRA (if any)
I have included migration files (if there are changes to the model classes)
I have included, reviewed and executed tests (unit and end2end) to complement my changes
I have updated the related documentation (if necessary)
I have added a reviewer for this pull request
I have added myself as an author for this pull request
In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

Co-authored-by: Viktor Sandström <[email protected]>

This reverts commit d321a3f.

churnikov · 2024-10-08T08:58:05Z

common/views.py

+
+        if user_form_details.is_valid() and profile_form_details.is_valid():
+
+            user_form_details.save()


This will have to be wrapped as a transaction I think

#Addressed it as follows: if user_form_details.is_valid() and profile_form_details.is_valid(): try: with transaction.atomic(): user_form_details.save() profile_form_details.save() logger.info( "Updated First Name: " + str(self.get_user_profile_info(request).user.first_name), exc_info=True `)` logger.info( "Updated Last Name: " + str(self.get_user_profile_info(request).user.last_name), exc_info=True ) logger.info( "Updated Department: " + str(self.get_user_profile_info(request).department), exc_info=True ) except Exception as e: return HttpResponse("Error updating records: " + str(e))

churnikov · 2024-10-08T09:48:20Z

templates/user/profile.html

+                        <h3 class="card-title mb-0">My user profile</h3>
+                        </div>
+                        <div class="col">
+                        <button type="button" type="submit" aria-expanded="false" class="btn btn-profile"><a href="{% url 'common:edit-profile' %}">Edit</a></button>


Suggested change

<button type="button" type="submit" aria-expanded="false" class="btn btn-profile"><a href="{% url 'common:edit-profile' %}">Edit</a></button>

<button type="button" type="submit" aria-expanded="false" class="btn btn-profile">

<a href="{% url 'common:edit-profile' %}">Edit</a>

</button>

Addressed it.

churnikov · 2024-10-08T09:48:49Z

templates/user/profile.html

-
+                    <div class="row">
+                        <div class="col">
+                        <h3 class="card-title mb-0">My user profile</h3>


Suggested change

<h3 class="card-title mb-0">My user profile</h3>

<h3 class="card-title mb-0">My user profile</h3>

fixed the indent

churnikov · 2024-10-08T10:06:46Z

templates/registration/edit_profile.html

@@ -0,0 +1,118 @@
+{% extends 'base.html' %}


I'd put this file in templates/user/ to other profile related templates

I'd like to suggest also, we change how this form looks like down the line to match the look of profile view.

But right now we should get this form to just work logic-wise

Moved to templates/user/

Edited the form to look like Profile form.

churnikov · 2024-10-08T10:09:37Z

templates/registration/edit_profile.html

+                                        {{form.email}}
+                                        <div class="form-text">{{form.email.help_text}}</div>
+                                        {% if form.email.errors %}
+                                        <div id="validation_email" class="invalid-feedback pt-1">


Seems like there is no need for this if it's not editable

And same goes for other fields

Added errors except the 'unchanged' ones.

churnikov · 2024-10-08T10:17:16Z

common/views.py

+            logger.info("Updated Last Name: "+str(self.get_user_profile_info(request).user.last_name), exc_info=True)
+            logger.info("Updated Department: "+str(self.get_user_profile_info(request).department), exc_info=True)
+
+            return render(request, "registration/edit_profile_done.html")


I personally think, that redirect should lead back to the userprofile view.

Do you think that this page is necessary?

Now redirect goes to profile view.

churnikov · 2024-10-09T07:55:13Z

common/views.py

@@ -206,7 +208,9 @@ def post(self, request, *args, **kwargs):
            # was invalid

            #print (form.errors)
-            logger.error("Edit user error: " + str(user_form_details.errors), exc_info=True)
-            logger.error("Edit profile error: " + str(profile_form_details.errors), exc_info=True)
+            if user_form_details.is_valid()==False:


Suggested change

if user_form_details.is_valid()==False:

if not user_form_details.is_valid():

rewrote it.

churnikov · 2024-10-09T07:55:33Z

common/views.py

-            logger.error("Edit profile error: " + str(profile_form_details.errors), exc_info=True)
+            if user_form_details.is_valid()==False:
+                logger.error("Edit user error: " + str(user_form_details.errors), exc_info=True)
+            if  profile_form_details.is_valid()==False:


Suggested change

if profile_form_details.is_valid()==False:

if not profile_form_details.is_valid():

rewrote it.

akochari and others added 7 commits April 19, 2024 15:53

Updated info about using Serve for teaching (#194)

d321a3f

Co-authored-by: Viktor Sandström <[email protected]>

Revert "Updated info about using Serve for teaching (#194)"

2b5cadc

This reverts commit d321a3f.

Merge branch 'staging' into main

2d769be

Merge branch 'staging'

ab7d54f

Merge branch 'staging'

46f589c

SS-643-Make-an-option-to-edit-account-details

c958069

SS-643-Make-an-option-to-edit-account-details

7c8099b

anondo1969 requested a review from churnikov October 7, 2024 14:30

anondo1969 self-assigned this Oct 7, 2024

churnikov reviewed Oct 8, 2024

View reviewed changes

SS-643 extending ProfileForm

4e3de76

churnikov requested changes Oct 9, 2024

View reviewed changes

anondo1969 added 3 commits October 10, 2024 13:37

SS-643 Updated edit HTML form

d38f4ce

SS-643 Updated edit HTML form

d86a443

SS-643 pre-commit check fixed

32b49eb

anondo1969 requested a review from churnikov October 10, 2024 14:04

anondo1969 added 2 commits October 10, 2024 16:10

SS-643 pre-commit with black check

bba6f8b

SS-643 pre-commit with black check 2

0048d66

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ss 643 make an option to edit account details #235

Ss 643 make an option to edit account details #235

anondo1969 commented Oct 7, 2024 •

edited

Loading

churnikov Oct 8, 2024

anondo1969 Oct 10, 2024

churnikov Oct 8, 2024

anondo1969 Oct 10, 2024

churnikov Oct 8, 2024

anondo1969 Oct 10, 2024

churnikov Oct 8, 2024

churnikov Oct 8, 2024

anondo1969 Oct 10, 2024

churnikov Oct 8, 2024

churnikov Oct 8, 2024

anondo1969 Oct 10, 2024

churnikov Oct 8, 2024

anondo1969 Oct 10, 2024

churnikov Oct 9, 2024

anondo1969 Oct 10, 2024

churnikov Oct 9, 2024

anondo1969 Oct 10, 2024


		if user_form_details.is_valid() and profile_form_details.is_valid():

		user_form_details.save()

	<h3 class="card-title mb-0">My user profile</h3>
	<h3 class="card-title mb-0">My user profile</h3>

	if user_form_details.is_valid()==False:
	if not user_form_details.is_valid():

	if profile_form_details.is_valid()==False:
	if not profile_form_details.is_valid():

Ss 643 make an option to edit account details #235

Are you sure you want to change the base?

Ss 643 make an option to edit account details #235

Conversation

anondo1969 commented Oct 7, 2024 • edited Loading

Status

Description

Types of changes

Checklist

Further comments

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anondo1969 commented Oct 7, 2024 •

edited

Loading