Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minio for s3 storage in dev #990

Closed
wants to merge 1 commit into from
Closed

Use minio for s3 storage in dev #990

wants to merge 1 commit into from

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Mar 3, 2022

Use minio for s3 storage during development

  • Adds a minio container for docker-compose
  • Updates the default values in config.py to enable a no-conf dev environment
  • Tests passing
  • Black formatting
  • [-] Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • [-] Note in the CHANGELOG

@talavis talavis requested a review from i-oden March 3, 2022 12:05
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #990 (ff9f747) into dev (7082d49) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #990      +/-   ##
==========================================
- Coverage   87.84%   87.80%   -0.04%     
==========================================
  Files          26       26              
  Lines        2904     2903       -1     
==========================================
- Hits         2551     2549       -2     
- Misses        353      354       +1     
Impacted Files Coverage Δ
dds_web/config.py 100.00% <100.00%> (ø)
dds_web/web/user.py 83.06% <0.00%> (-0.54%) ⬇️
dds_web/forms.py 97.29% <0.00%> (-0.08%) ⬇️
dds_web/api/user.py 87.53% <0.00%> (-0.04%) ⬇️
dds_web/api/project.py 90.13% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7082d49...ff9f747. Read the comment docs.

@talavis talavis self-assigned this Mar 3, 2022
Copy link
Contributor

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay easier testing 👏🏻

Maybe worth adding some mention of it to the docs? Also changelog.

@talavis
Copy link
Contributor Author

talavis commented Mar 3, 2022

Will be merged with #993

@talavis talavis closed this Mar 3, 2022
@talavis talavis deleted the minio-dev branch March 4, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants