Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting the correct ip when behind a reverse proxy #952

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Feb 28, 2022

  • Tests passing
  • Black formatting
  • Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #952 (38f39bf) into dev (592ad6b) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #952      +/-   ##
==========================================
- Coverage   87.91%   87.89%   -0.02%     
==========================================
  Files          26       26              
  Lines        2895     2899       +4     
==========================================
+ Hits         2545     2548       +3     
- Misses        350      351       +1     
Impacted Files Coverage Δ
dds_web/__init__.py 71.66% <66.66%> (-0.13%) ⬇️
dds_web/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592ad6b...38f39bf. Read the comment docs.

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Testing it out locally with your instructions will take more time than I have at the moment so I'm approving.

@i-oden i-oden merged commit 15ff173 into dev Feb 28, 2022
@i-oden i-oden mentioned this pull request Feb 28, 2022
@talavis talavis deleted the proxy-support branch March 2, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants