Relax username requirements a little

[ewels]

Minor changes to username requirements, needs agreement in meeting:

• Allow . and - in usernames
• Relax length requirements to 3-30 characters instead of 8-20

• Tests passing
• Black formatting
• Migrations for any changes to the database schema
• Rebase/merge the dev branch
• Note in the CHANGELOG

[ewels]

Not sure why the tests are failing? Seems unrelated to the PR changes I think..

[i-oden]

Not sure why the tests are failing? Seems unrelated to the PR changes I think..

Yep, it's the db encryption, have commented out the volumes in the db part of the docker-compose for now and then it works

[i-oden]

Now you should be able to merge dev and then the tests should pass

[ewels]

I don't have permissions to merge :)

[i-oden]

I meant merge dev into this branch.

[i-oden]

So that the docker-compose change is in this too and the tests pass

[i-oden]

@ewels Could you also add an entry in the changelog?

[codecov]

Codecov Report

Merging #943 (ddfae4f) into dev (15ff173) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #943      +/-   ##
==========================================
+ Coverage   87.89%   87.90%   +0.01%     
==========================================
  Files          26       26              
  Lines        2899     2894       -5     
==========================================
- Hits         2548     2544       -4     
+ Misses        351      350       -1     

Impacted Files	Coverage Δ
dds_web/api/schemas/user_schemas.py	92.94% <ø> (ø)
dds_web/forms.py	97.36% <ø> (ø)
dds_web/utils.py	76.83% <100.00%> (-0.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ff173...ddfae4f. Read the comment docs.

[i-oden]

Just tested: Do we want to allow usernames containing all or almost all special characters?

[ewels]

If in doubt, copy what GitHub does..? 😀

https://github.com/shinnn/github-username-regex#github-username-regex

• Github username may only contain alphanumeric characters or hyphens.
• Github username cannot have multiple consecutive hyphens.
• Github username cannot begin or end with a hyphen.
• Maximum is 39 characters.

Actually quite restrictive.. Drop-in regex: /^[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}$/i

Personally I'm happy with what's in this PR..

[i-oden]

@ewels Ok I will add this as a possible future change since it's not a high priority, but I will approve and merge this PR now 👍🏻