Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landing page after password reset #931

Merged
merged 5 commits into from
Feb 23, 2022

Conversation

aanil
Copy link
Contributor

@aanil aanil commented Feb 23, 2022

  • Tests passing
  • Black formatting
  • Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@aanil aanil self-assigned this Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #931 (f734137) into dev (5ac03f6) will decrease coverage by 0.09%.
The diff coverage is 75.00%.

❗ Current head f734137 differs from pull request most recent head 0285c0a. Consider uploading reports for the commit 0285c0a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #931      +/-   ##
==========================================
- Coverage   88.15%   88.06%   -0.10%     
==========================================
  Files          26       26              
  Lines        2804     2823      +19     
==========================================
+ Hits         2472     2486      +14     
- Misses        332      337       +5     
Impacted Files Coverage Δ
dds_web/web/user.py 82.40% <75.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac03f6...0285c0a. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@i-oden
Copy link
Member

i-oden commented Feb 23, 2022

Looks good @aanil

Copy link
Contributor

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! I think we might want to have slightly different page content for different types of users in the future but this sort of works for unit users as well.

@i-oden
Copy link
Member

i-oden commented Feb 23, 2022

Looks good and works well! I think we might want to have slightly different page content for different types of users in the future but this sort of works for unit users as well.

Yes I think this works for now and we can improve on it

@i-oden i-oden merged commit 59a23b3 into ScilifelabDataCentre:dev Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants