Key derivation #889
Merged
Key derivation #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Make it possible to get hold of the current encrypted token and its contents at the endpoints and the key operations, Introduce new errors for exceptional situations regarding token and keys, Remove temporary_key from user model, Derive user key from users password, Generate user key pair using the derived user key, Include sensitive content in the encrypted token, Update development and test db setup accordingly, Update some existing tests accordingly, Clean up some unused imports and Fix minor syntax issues encountered
|
The work is completed and ready to review. |
Codecov Report
@@ Coverage Diff @@
## dev #889 +/- ##
==========================================
+ Coverage 75.42% 76.29% +0.87%
==========================================
Files 29 29
Lines 2856 2915 +59
==========================================
+ Hits 2154 2224 +70
+ Misses 702 691 -11
Continue to review full report at Codecov.
|
worukan
commented
Feb 16, 2022
…ted token, Add tests for invite and encrypted token, and authentication
…llision with the password hasher parameter
…for this and Clean up some unused imports
i-oden
reviewed
Feb 17, 2022
i-oden
reviewed
Feb 17, 2022
i-oden
requested changes
Feb 17, 2022
There was a problem hiding this comment.
Looks good. Some variable names and docstrings etc needed but also not super vital and as with the last PR I can add it at some point.
I think you should make a note in the comment section that we need to do dds auth logout and then login again for this to work.
Also:
dds_backend | [2022-02-17 10:43:06,633] project [DEBUG] Getting the private key.
dds_backend | 172.19.0.1 - - [17/Feb/2022 10:43:06] "GET /api/v1/proj/private?project=someunit00004 HTTP/1.1" 500 -
dds_backend | Traceback (most recent call last):
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 2091, in __call__
dds_backend | return self.wsgi_app(environ, start_response)
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 2076, in wsgi_app
dds_backend | response = self.handle_exception(e)
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask_restful/__init__.py", line 271, in error_router
dds_backend | return original_handler(e)
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 2073, in wsgi_app
dds_backend | response = self.full_dispatch_request()
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1518, in full_dispatch_request
dds_backend | rv = self.handle_user_exception(e)
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask_restful/__init__.py", line 271, in error_router
dds_backend | return original_handler(e)
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1516, in full_dispatch_request
dds_backend | rv = self.dispatch_request()
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1502, in dispatch_request
dds_backend | return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask_restful/__init__.py", line 467, in wrapper
dds_backend | resp = resource(*args, **kwargs)
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask/views.py", line 84, in view
dds_backend | return current_app.ensure_sync(self.dispatch_request)(*args, **kwargs)
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask_restful/__init__.py", line 582, in dispatch_request
dds_backend | resp = meth(*args, **kwargs)
dds_backend | File "/usr/local/lib/python3.10/site-packages/flask_httpauth.py", line 172, in decorated
dds_backend | return self.ensure_sync(f)(*args, **kwargs)
dds_backend | File "/code/dds_web/api/dds_decorators.py", line 107, in wrapper_logging_bind_request
dds_backend | value = func(*args, **kwargs)
dds_backend | File "/code/dds_web/api/project.py", line 243, in get
dds_backend | {"private": obtain_project_private_key(auth.current_user(), project).hex().upper()}
dds_backend | TypeError: obtain_project_private_key() missing 1 required positional argument: 'project'
I didn't understand this. Could you please clarify? |
I try to download so the private key is needed and then I get this traceback. |
This seems like a bug for ProjectRequiredSchema. I will investigate... |
Problem found! It's because of the additional required token. Fixing it and writing more tests... |
alneberg
reviewed
Feb 17, 2022
alneberg
reviewed
Feb 17, 2022
…ns with token, Add tests for it, Rearrange and clarify some key related parameters, Clean up some unused imports
alneberg
approved these changes
Feb 17, 2022
i-oden
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the way an invite token is verified and transferred to a user, Make it possible to get hold of the current encrypted token and its contents at the endpoints and the key operations, Introduce new errors for exceptional situations regarding token and keys, Remove temporary_key from user model, Derive user key from users password, Generate user key pair using the derived user key, Include sensitive content in the encrypted token, Update development and test db setup accordingly, Update some existing tests accordingly, Clean up some unused imports and Fix minor syntax issues encountered
Closes #738