DDS-1906 store raw Tech Overview #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is not the PDF which is currently displayed so is obsolete. - Git can keep the history of the older PDFs for us.
aishling-scilifelab
force-pushed
the
DDS-1906-store-raw-tech-overview
branch
from
1264a0c
to
f2731c5
Compare
- Raw (i.e. not PDF) doc was kept out of repo. Move here for tracking - Some minor formatting changes relate to previous PDF (e.g. updated font to Lato to match web) - Deleted Section 3: 'What is the invoicing model?'. This is not technical information. We should make this available elsewhere. Also, this info is only relevant to users using the DC-hosted instance. - Add individual SVG files for the images in the overview - Delete PDFs of images - Update SPRINTLOG.md with PR - Set prettier to ignore technical-overview.md. As noted, it is not formatting the grid tables correctly. - Next step is creating PDF as GitHub Action (hence no docs on creating PDF from MD).
aishling-scilifelab
force-pushed
the
DDS-1906-store-raw-tech-overview
branch
from
f2731c5
to
7b16b4b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1539 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 29 29
Lines 4850 4850
=======================================
Hits 4486 4486
Misses 364 364 ☔ View full report in Codecov by Sentry. |
|
Didn't saw any big changes in the end result of the pdf. Only some style changes, I guess because of being compiled differently. But nothing crazy. |
rv0lt
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read this before submitting the PR
If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Add a summary of the changes in this PR and the related issue.
2. Jira task / GitHub issue
Link to the github issue or add the Jira task ID here.
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
masterbranch: _If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.