Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dds 1686 Fixed black version on GitHub Actions - update code to black 24.1.1 #1510

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Jan 29, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Use of a fixed version of black in the GitHub Actions to avoid incompatibilities with already existing code when a new mayor upgrade of black is done.

Update of existing code to the standard of black version 24.1.1

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

@rv0lt rv0lt self-assigned this Jan 29, 2024
@rv0lt rv0lt marked this pull request as ready for review January 29, 2024 15:06
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c77130b) 91.48% compared to head (9ca8bf6) 91.48%.

Files Patch % Lines
dds_web/api/project.py 0.00% 1 Missing ⚠️
dds_web/api/user.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1510   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          29       29           
  Lines        4637     4637           
=======================================
  Hits         4242     4242           
  Misses        395      395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rv0lt
Copy link
Member Author

rv0lt commented Jan 29, 2024

Ignore codecov missing lines as this PR do NOT alter any part of the code, only applies black standar linting to already existing code

@rv0lt rv0lt requested a review from a team January 29, 2024 15:11
@rv0lt rv0lt merged commit bdc8a8b into dev Jan 30, 2024
14 checks passed
@rv0lt rv0lt deleted the DDS-1686-Black-version-should-be-the-same-locally-and-on-Github-actions branch January 30, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants