Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "/tmp/" as csv file location #1499

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

valyo
Copy link
Member

@valyo valyo commented Dec 13, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

The new command flask send-usage fails on our production and testing instances with the following error:

OSError: [Errno 30] Read-only file system: 'snpseq_Usage_Months-11-to-11.csv

The reason is that in these environments we are running the containers as non-root (in contrast to our dev environment, separate task for this should be created and linked).

2. Jira task / GitHub issue

https://scilifelab.atlassian.net/browse/DDS-1845

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (034874a) 91.50% compared to head (3491e77) 91.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1499   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files          29       29           
  Lines        4624     4625    +1     
=======================================
+ Hits         4231     4232    +1     
  Misses        393      393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valyo valyo marked this pull request as ready for review December 13, 2023 08:13
@valyo valyo requested a review from a team December 13, 2023 08:13
@valyo valyo merged commit 2a82d7f into dev Dec 13, 2023
14 checks passed
@valyo valyo deleted the DDS-1845-write-usage-csv-file-in-tmp branch December 13, 2023 08:30
@i-oden
Copy link
Member

i-oden commented Aug 20, 2024

Question: Just double checking so that we're sure that the tmp folder in production is not emptied etc prior to us having the files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants