Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update urllib3 package to address vulnerabities #1487

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Nov 7, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Update urrllib3 to solve known vulnerabilities


Urllib3 is a Python package used as an HTTP client. It is not used by us in any parts of the code, but by other packages. Such as requests (for the testing modules)

The changes are minor and no backward incompatible changes
Changelog

The pipdeptree output show no incompatibility with updating from 1.26.8 to 1.26.18 either

urllib3==1.26.18
├── botocore==1.23.47 [requires: urllib3>=1.25.4,<1.27]
└── requests-cache==0.9.4 [requires: urllib3>=1.25.5,<2.0.0]

2. Jira task / GitHub issue

https://scilifelab.atlassian.net/jira/software/projects/DDS/boards/13?selectedIssue=DDS-1822

3. What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
    • Package update
      • Major update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

@rv0lt rv0lt self-assigned this Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1487 (b955ac2) into dev (a0e24c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1487   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          29       29           
  Lines        4617     4617           
=======================================
  Hits         4224     4224           
  Misses        393      393           

@rv0lt rv0lt changed the title update package update urllib3 package to address vulnerabities Nov 7, 2023
@rv0lt rv0lt marked this pull request as ready for review November 7, 2023 13:10
@rv0lt rv0lt requested a review from a team November 7, 2023 13:43
@i-oden
Copy link
Member

i-oden commented Nov 9, 2023

Urllib3 is a Python package used as an HTTP client. It is not used by us in any parts of the code, but by other packages.

Hmm haven't thought of this. I thought we also used it, but seems we don't, we use urllib.. Not sure if there's a reason we're not using urllib3. Nothing to change here obviously but maybe something to look into at some point.

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see anything strange in the changelog and seems to be no issues.

@rv0lt rv0lt merged commit e48ce8a into dev Nov 9, 2023
14 checks passed
@rv0lt rv0lt deleted the DDS-1822-Fix-CVE-2023-45803 branch November 9, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants