Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify checksum flag to the email when project release #1478

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Oct 6, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Add the flag --verify-checksum to the command example in the email template

2. Jira task / GitHub issue

https://scilifelab.atlassian.net/jira/software/projects/DDS/boards/13?selectedIssue=DDS-1409

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1478 (2bdd4ce) into dev (b14b1cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1478   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files          29       29           
  Lines        4426     4426           
=======================================
  Hits         3992     3992           
  Misses        434      434           

@rv0lt rv0lt marked this pull request as ready for review October 6, 2023 10:42
@rv0lt rv0lt changed the title new templates Add verify checksum flag to the email when project release Oct 6, 2023
@rv0lt rv0lt requested a review from i-oden October 6, 2023 12:22
SPRINTLOG.md Outdated Show resolved Hide resolved
@rv0lt rv0lt requested a review from i-oden October 6, 2023 13:28
@i-oden
Copy link
Member

i-oden commented Oct 6, 2023

@rv0lt You can merge when the checks have passed -- up to you if you want to do that today or wait until Monday

@rv0lt rv0lt merged commit fe4d13d into dev Oct 6, 2023
14 checks passed
@rv0lt rv0lt deleted the DDS-1409-Add-verify-checksum-to-the-notification-email branch October 6, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants