-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sto4_start_time column to be initialized on unit creation #1469
Added sto4_start_time column to be initialized on unit creation #1469
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1469 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 29 29
Lines 4407 4408 +1
=======================================
+ Hits 3973 3974 +1
Misses 434 434
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we'll need to change the test dds_web/tests/test_commands.py::test_create_new_unit_success
so that it checks that the sto4_start_time
variable is set. In this case it would be good if you checked that only all sto4*
variables were set and not sto2*
.
@i-oden Should I also add checks for the rest of the parameters now that I am modiying this test. As right now only checks that the name was correct ? |
Yeah, you can do that, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@rv0lt just rerun the tests, there's no actual error. We know about this bug since before, it does this sometimes |
Read this before submitting the PR
1. Description / Summary
Now the column Sto4_Start_time will automatically be set in the Units table when the create-unit command is run. Instead of having to run the upgrade unit.
2. Jira task / GitHub issue
https://scilifelab.atlassian.net/jira/software/projects/DDS/boards/13?selectedIssue=DDS-1668
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
master
branch: _If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.