Expired link is deleted from database when expired

[rv0lt]

Before submitting this PR

1. Description: When an invite is sent, the expiry time is set to exactly 7 days from now (incl the time). At midnight there is a cronjob which finds the expired invites in the Invites table and removes them. This means that there is a gap between the actual expiry and when the invite is deleted from the database. This PR fixes that. As well as adding some tests

2. Jira task / GitHub issue: https://scilifelab.atlassian.net/jira/software/projects/DDS/boards/13?isInsightsOpen=true&selectedIssue=DDS-1642

3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.

4. Type of change: Check the relevant boxes in the section below

5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

• New feature
  • Breaking: Please describe the reason for the break and how we can fix it.
  • Non-breaking
• Database change
  • Migration included in PR
  • Migration not needed
• Bug fix
  • Breaking: Please describe the reason for the break and how we can fix it.
  • Non-breaking
• Security Alert fix
• Documentation
• Tests (only)
• Workflow

Checklist

• Sprintlog
  • Added
  • Not needed (E.g. PR contains only tests)
• Rebase / Update / Merge from base branch (the branch from which the current is forked)
  • Done
  • Not needed
• Blocking PRs
  • Merged
  • No blocking PRs
• PR to master branch
  • Yes: Read the release instructions
    • I have followed steps 1-8.
  • No

Actions / Scans

• Black: Python code formatter. Does not execute. Only tests.
  Run black . locally to execute formatting.
  • Passed
• Prettier: General code formatter. Our use case: MD and yaml mainly.
  Run npx prettier --write . locally to execute formatting.
  • Passed
• Yamllint: Linting of yaml files.
  • Passed
• Tests: Pytest to verify that functionality works as expected.
  • New tests added
  • No new tests
  • Passed
• CodeQL: Scan for security vulnerabilities, bugs, errors
  • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
  • Alerts fixed: What?
  • Alerts ignored / dismissed: Why?
  • Passed
• Trivy: Security scanner
  • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
  • Alerts fixed: What?
  • Alerts ignored / dismissed: Why?
  • Passed
• Snyk: Security scanner
  • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
  • Alerts fixed: What?
  • Alerts ignored / dismissed: Why?
  • Passed

[codecov]

Codecov Report

Merging #1466 (753ead3) into dev (ca45daf) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1466      +/-   ##
==========================================
+ Coverage   90.11%   90.15%   +0.03%     
==========================================
  Files          29       29              
  Lines        4401     4407       +6     
==========================================
+ Hits         3966     3973       +7     
+ Misses        435      434       -1     

Files Changed	Coverage Δ
dds_web/api/schemas/user_schemas.py	88.88% <100.00%> (+0.65%)	⬆️
dds_web/api/user.py	90.63% <100.00%> (+0.20%)	⬆️

[rv0lt]

@i-oden You mean adding tests that check that the ProjectInviteKeys are removed right?

[i-oden]

@i-oden You mean adding tests that check that the ProjectInviteKeys are removed right?

@rv0lt Correct!

[i-oden]

Looks good! Few comments / suggestions

• Change the title of the PR so that it reflects the changes (expired invite deleted when new invite attempted or something like that)
• Fix / clarify a few things in the tests
• Add a test for the SQLAlchemyError. You don't need to add for the OperationalError, it's more complicated and it will anyway produce the same message. Tip: Check the codecov report further up in this PR (see image below). The percentage within the <> brackets should be 100% or as close to it as possible (if not 100 then explain why / discuss with us for example) for the files that are listed in the table. That means that 100% of your code changes are covered by tests.

[rv0lt]

@i-oden like this changes I push you mean? I dont know How to check for example for the ddserr.databaseerror as that was already part of the code I just move it around.

[i-oden]

@i-oden like this changes I push you mean? I dont know How to check for example for the ddserr.databaseerror as that was already part of the code I just move it around.

What you've added now is a good start, but you'll need to change a bit and add a bit of code too. I can have a look tomorrow again and come with a suggestion!

[i-oden]

Suggestions regarding the tests

[i-oden]

Looks great and now the test coverage of your changes is 100% 👏🏻

Just a couple of very minor changes, just for consistency, then I'm ready to approve.

[i-oden]

Good job!

Once @valyo has also approved, you can merge it.

[valyo]

Looks good and works as expected. Just small corrections in the tests docstrings