Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sto2 vars as nullable #1462

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Set sto2 vars as nullable #1462

merged 3 commits into from
Sep 7, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Sep 7, 2023

Before submitting this PR

  1. Description: When Erik was trying to add a new unit to the testing instance, he got an error message saying that sto2* arguments could not be null. It appears that we never set them to nullable in the database when we added the sto4 variables. This PR does that.
  2. Jira task / GitHub issue: DDS-1663
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

  • New feature
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Database change
    • Migration included in PR
    • Migration not needed
  • Bug fix
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Security Alert fix
  • Documentation
  • Tests (only)
  • Workflow

Checklist

  • Sprintlog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1462 (e029629) into dev (190e114) will increase coverage by 0.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1462      +/-   ##
==========================================
+ Coverage   89.51%   90.05%   +0.54%     
==========================================
  Files          29       29              
  Lines        4396     4396              
==========================================
+ Hits         3935     3959      +24     
+ Misses        461      437      -24     
Files Changed Coverage Δ
dds_web/database/models.py 96.18% <100.00%> (ø)

... and 1 file with indirect coverage changes

@i-oden i-oden merged commit 820cb63 into dev Sep 7, 2023
15 checks passed
@i-oden i-oden deleted the DDS-1663-bug-in-new-unit-command branch September 7, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant