Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change message when project is busy #1450

Merged
merged 15 commits into from
Aug 21, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Aug 2, 2023

Before submitting this PR

  1. Description: There is a message being displayed about the project being busy with upload, download etc, but this functionality has been changed. The projects are only set as busy during status changes. This updates the message.
  2. Jira task / GitHub issue: DDS-1588
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

  • New feature
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Database change
    • Migration included in PR
    • Migration not needed
  • Bug fix
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Security Alert fix
  • Documentation
  • Tests (only)
  • Workflow

Checklist

  • Sprintlog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Aug 2, 2023
@i-oden i-oden requested a review from valyo August 2, 2023 11:25
@i-oden i-oden removed the request for review from valyo August 3, 2023 08:58
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1450 (64549be) into dev (ef9f198) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1450   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files          29       29           
  Lines        4389     4390    +1     
=======================================
+ Hits         3928     3929    +1     
  Misses        461      461           
Files Changed Coverage Δ
dds_web/api/project.py 89.78% <100.00%> (+0.02%) ⬆️

@i-oden i-oden requested a review from valyo August 3, 2023 09:23
@i-oden i-oden marked this pull request as ready for review August 9, 2023 12:21
@valyo valyo changed the title Change message when user is busy Change message when project is busy Aug 10, 2023
dds_web/api/project.py Show resolved Hide resolved
@i-oden i-oden requested a review from valyo August 10, 2023 13:23
dds_web/api/project.py Outdated Show resolved Hide resolved
@i-oden i-oden requested a review from valyo August 17, 2023 07:36
@i-oden i-oden merged commit 2741913 into dev Aug 21, 2023
14 checks passed
@i-oden i-oden deleted the DDS-1588-change-message-displayed-when-project-busy branch August 21, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants