Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 2.4.0 #1443

Merged
merged 4 commits into from
Jun 28, 2023
Merged

New version 2.4.0 #1443

merged 4 commits into from
Jun 28, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Jun 28, 2023

Before submitting this PR

  1. Description: Update version to 2.4.0 and changelog
  2. Jira task / GitHub issue: DDS-1610
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

  • New feature
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Database change
    • Migration included in PR
    • Migration not needed
  • Bug fix
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Security Alert fix
  • Documentation
  • Tests (only)
  • Workflow

Checklist

  • Sprintlog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Jun 28, 2023
@i-oden i-oden requested a review from valyo June 28, 2023 08:12
@i-oden i-oden marked this pull request as ready for review June 28, 2023 08:15
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1443 (ff57f0c) into dev (ffabef9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1443   +/-   ##
=======================================
  Coverage   89.42%   89.42%           
=======================================
  Files          29       29           
  Lines        4314     4314           
=======================================
  Hits         3858     3858           
  Misses        456      456           
Impacted Files Coverage Δ
dds_web/version.py 100.00% <100.00%> (ø)

@i-oden i-oden merged commit c8917bf into dev Jun 28, 2023
@i-oden i-oden deleted the new-version-2.3.1 branch June 28, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants