-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: save amount of data since start #1430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs test and sprintlog
The test did not behave as I expected and I used an approach similar to yours in #1431, but I am not 100% sure if it makes sense |
I'll have a look! |
Tests are failing locally, but at a different place, checking it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected!
Before submitting this PR
What type of change(s) does the PR contain?
Checklist
master
branchActions / Scans
Run
black .
locally to execute formatting.Run
npx prettier --write .
locally to execute formatting.